-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/simple sensor simulator unit tests part3 #29
base: feature/simple_sensor_simulator_unit_tests_part2
Are you sure you want to change the base?
Feature/simple sensor simulator unit tests part3 #29
Conversation
- Added unit tests to DetectionSensor
- Added new line at the end of test_detection_sensor.hpp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove repeated functions if possible; in test_lidar_sensor.hpp and test_detection_sensor_hpp.
...imple_sensor_simulator/test/src/sensor_simulation/detection_sensor/test_detection_sensor.hpp
Outdated
Show resolved
Hide resolved
...imple_sensor_simulator/test/src/sensor_simulation/detection_sensor/test_detection_sensor.hpp
Outdated
Show resolved
Hide resolved
...imple_sensor_simulator/test/src/sensor_simulation/detection_sensor/test_detection_sensor.hpp
Outdated
Show resolved
Hide resolved
...imple_sensor_simulator/test/src/sensor_simulation/detection_sensor/test_detection_sensor.cpp
Outdated
Show resolved
Hide resolved
...imple_sensor_simulator/test/src/sensor_simulation/detection_sensor/test_detection_sensor.cpp
Outdated
Show resolved
Hide resolved
...imple_sensor_simulator/test/src/sensor_simulation/detection_sensor/test_detection_sensor.hpp
Outdated
Show resolved
Hide resolved
...imple_sensor_simulator/test/src/sensor_simulation/detection_sensor/test_detection_sensor.hpp
Outdated
Show resolved
Hide resolved
...imple_sensor_simulator/test/src/sensor_simulation/detection_sensor/test_detection_sensor.hpp
Outdated
Show resolved
Hide resolved
…feature/simple_sensor_simulator_unit_tests_part3
- Refactored DetectionSensor tests - Refactored LidarSensor tests
I have refactored LidarSensor also... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
...imple_sensor_simulator/test/src/sensor_simulation/detection_sensor/test_detection_sensor.cpp
Outdated
Show resolved
Hide resolved
- Refactored DetectionSensor tests
- Added unit tests to TrafficLightsDetector
- Refactored TrafficLightDetector unit tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Description
Abstract
This PR contains unit tests for:
Details
References
Jira ticket: link
Destructive Changes
There are no destructive changes